json-schema-org / website

JSON Schema website
https://json-schema.org
Other
67 stars 177 forks source link

link-redirect-fix #1042

Closed Yashwanth1906 closed 1 month ago

Yashwanth1906 commented 1 month ago

What kind of change does this PR introduce?

Bugfix: Fixes misdirection of pages. Issue Number:

Closes #1038 Related to #___ Others? Screenshots/videos:

If relevant, you can add screenshots or videos showing the issue and how it was fixed. If relevant, did you update the documentation?

No documentation updates were needed. Summary

This PR fixes a bug that caused misdirection of certain pages in the app. The routing logic was adjusted to correctly map the pages to their intended destinations. Does this PR introduce a breaking change?

No, this PR does not introduce a breaking change.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.47%. Comparing base (7ecd915) to head (913e29f).

Files with missing lines Patch % Lines
components/DocsHelp.tsx 77.77% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1042 +/- ## =========================================== - Coverage 100.00% 99.47% -0.53% =========================================== Files 10 10 Lines 373 380 +7 Branches 94 97 +3 =========================================== + Hits 373 378 +5 - Misses 0 2 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

IyaadDev commented 1 month ago

looks great, but would it be possible to clarify:

Yashwanth1906 commented 1 month ago

looks great, but would it be possible to clarify:

  • the purposes of 'pages/overview/code-of-conduct/_index.md' and 'pages/overview/sponsors/_index.md',
  • the modifications to project dependencies
  • the new hyper-schema section
Yashwanth1906 commented 1 month ago

Ill Fork the repo again and create a new pull request soon @DhairyaMajmudar . Thank you

DhairyaMajmudar commented 1 month ago

Ill Fork the repo again and create a new pull request soon @DhairyaMajmudar . Thank you

No need to fork and create pr again you can commit changes in this PR also