json-schema-org / website

JSON Schema website
https://json-schema.org
Other
64 stars 163 forks source link

🐛 Bug: Some Section need's Improvement #1057

Open officeneerajsaini opened 5 days ago

officeneerajsaini commented 5 days ago

Describe the bug

I encountered an issue with the navbar when dark mode is enabled. I'm unable to see which page I'm currently navigating to because there is no visible active element. Typically, the active route or page is highlighted with a different color, but in dark mode, all the navbar items appear the same.

Screenshot 2024-10-23 at 5 03 19 PM

Steps To Reproduce

  1. Turn on Dark Mode
  2. Check the Active Item of Navbar

Expected Behavior

In dark mode, it's hard to see which page we're currently on. There should be an active color for the navbar items so the current page is clearly visible.

Screenshot 2024-10-23 at 5 03 07 PM

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

NO

officeneerajsaini commented 5 days ago

I found another issue on the community page. In the Upcoming Events section, if there are four dates, everything looks fine, but if there are five, the background color of one of the divs doesn't appear. I initially styled it for four divs only, so I need to add an additional CSS class to ensure it looks as it should.

Screenshot 2024-10-23 at 5 00 04 PM

solution should be

Screenshot 2024-10-23 at 5 02 02 PM Screenshot 2024-10-23 at 5 04 22 PM
Utkarsh-Agarwal-585 commented 5 days ago

hI @officeneerajsaini can I start work on this? Please assign it to me!

officeneerajsaini commented 5 days ago

@Utkarsh-Agarwal-585, please read this issue carefully. As I mentioned earlier, I am already working on it, and like you, I am a contributor, not a member of the JSON Schema project.

officeneerajsaini commented 5 days ago

There are other issues in this repo that you can look into. Feel free to ask a maintainer or collaborator to assign one to you. Please leave this issue to me. @Utkarsh-Agarwal-585

officeneerajsaini commented 5 days ago

@DhairyaMajmudar please assign this issue to me.

DhairyaMajmudar commented 5 days ago

Looking forward for your PR @officeneerajsaini