search

json-schema-org / website

JSON Schema website
https://json-schema.org
Other
67 stars 175 forks source link

Fix: Sidebar position sticky #1086

Open techmannih opened 3 weeks ago

techmannih commented 3 weeks ago

What kind of change does this PR introduce? This PR introduces a sticky sidebar position, allowing the sidebar to remain fixed in view while the user scrolls down the page.

Issue Number: Issue #774 Closes #774

Screenshots/videos:

https://github.com/user-attachments/assets/9f203402-d5ae-4666-8f41-53beb27f34cf

github-actions[bot] commented 3 weeks ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview ab281bb1f0ae901dfa42c57cdf194709f231cdd1
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (718dab5) to head (ab281bb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1086 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 10 10 Lines 373 373 Branches 94 94 ========================================= Hits 373 373 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DhairyaMajmudar commented 3 weeks ago

@techmannih the sidebar should be sticky to such high extend.

image

techmannih commented 3 weeks ago

@DhairyaMajmudar I’m unable to understand your point. Please explain. I think it's sticky also

DhairyaMajmudar commented 3 weeks ago

@DhairyaMajmudar I’m unable to understand your point. Please explain. I think it's sticky also

I meant the sidebar should not be sticky to upto need help headline only below that the footer sections are there.

techmannih commented 3 weeks ago

you mean change the height now it covers full "need help" section image

techmannih commented 1 week ago

@DhairyaMajmudar Could you please clarify what you need? I’m having some difficulty understanding.

DhairyaMajmudar commented 1 week ago

@techmannih I was worried about the less bottom margin for the sidebar cause of which it was getting patched up with need help section you can check the video below

Screencast from 2024-11-10 12-07-28.webm

The expected behavior should be like this : )

Screencast from 2024-11-10 12-10-15.webm

techmannih commented 1 week ago

Thanks @DhairyaMajmudar, it's a great clarification! Now I get your point clearly. please review now

techmannih commented 5 days ago

@DhairyaMajmudar, please review this PR