json-schema-org / website

JSON Schema website
https://json-schema.org
Other
67 stars 175 forks source link

Enhancement : hide edit this on github #1114

Open arpitkuriyal opened 1 week ago

arpitkuriyal commented 1 week ago

What kind of change does this PR introduce?

Add a prop that default feature is to show the "edit this on github " button but when pass false it hide that button

Issue Number:

Screenshots/videos:

Screenshot 2024-11-14 at 3 35 06 PM

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

github-actions[bot] commented 1 week ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 71e2039f6a09f74b91ee23e70035ad2350407057
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.73%. Comparing base (9899bc7) to head (71e2039).

Files with missing lines Patch % Lines
components/DocsHelp.tsx 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1114 +/- ## =========================================== - Coverage 100.00% 99.73% -0.27% =========================================== Files 10 10 Lines 373 375 +2 Branches 94 97 +3 =========================================== + Hits 373 374 +1 - Misses 0 1 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gregsdennis commented 1 week ago

Please see my comment on the issue

https://github.com/json-schema-org/website/issues/1099#issuecomment-2476117696