search

json-schema-org / website

JSON Schema website
https://json-schema.org
Other
67 stars 175 forks source link

Link-Redirect-fix-DocsHelp-Component #1117

Open Yashwanth1906 opened 5 days ago

Yashwanth1906 commented 5 days ago

What kind of change does this PR introduce? Change to correct wrong redirecting URLs Issue Number: closes: https://github.com/json-schema-org/website/issues/1038

Screenshots/videos:

If relevant, did you update the documentation?

Summary

This pull request addresses an issue related to incorrect URL redirection in the JSON Schema website. Users were being redirected to incorrect or unintended pages when clicking on certain links.

Changes Made: Corrected Redirecting URLs: Updated the wrong redirecting URLs in various components to ensure they point to the correct destinations. This change enhances navigation and provides users with access to the intended content.

Refactored JSX Components: Adjusted the formatting of JSX components to comply with the project's style guide. Specifically, I ensured that there were proper spaces before closing brackets in the JSX tags, addressing the errors raised by the reviewers.

Code Consistency: Ensured consistency in the codebase by adhering to Prettier and ESLint rules, which included correcting formatting issues to enhance code readability and maintainability.

These changes improve user experience by ensuring that links function correctly, reducing frustration caused by misdirected navigation.

Does this PR introduce a breaking change?

No

github-actions[bot] commented 5 days ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 16f2f329e814046cb99aef2d51ddf8b5ae65e4e9
codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9899bc7) to head (16f2f32).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1117 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 10 10 Lines 373 381 +8 Branches 94 97 +3 ========================================= + Hits 373 381 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Yashwanth1906 commented 5 days ago

@DarhkVoyd This is the new pull request for this closed pull request #1046 because of some git pull rebase issues. I have written all the tests and changed all the corrections that you said in that #1046 closed pull request. Sry for closing that pull request.

Yashwanth1906 commented 3 days ago

@aialok Is everything fine with the pr ? Is there any one want to review it?