json-schema-org / website

JSON Schema website
https://json-schema.org
Other
40 stars 120 forks source link

Bug : Update route from /implementations to /tools #394

Open aialok opened 4 months ago

aialok commented 4 months ago

Describe the bug

Screenshot from 2024-02-29 23-33-39

Expected behavior

DhairyaMajmudar commented 4 months ago

Good find @aialok : D

officeneerajsaini commented 4 months ago

Yeah, that's great, @aialok . We need to change the route from 'implementation' to 'tools' and also create a redirection route so we can redirect '/implementation' to '/tools.

aialok commented 4 months ago

Yeah, that's great, @aialok . We need to change the route from 'implementation' to 'tools' and also create a redirection route so we can redirect '/implementation' to '/tools.

Yupp @officeneerajsaini , we are also facing page not found error in mobile phone. Because of this only.

officeneerajsaini commented 4 months ago

It issue not only occur in mobile it also occur in any other devices because we try to get request from a route that not exits so , we need to make changes in route and also need to make a redirect link so if someone try to get request on "/implementations" route it will redirect to "/tools" @aialok

benjagm commented 4 months ago

The implementations url is probably being used from hundreds of sites se we can't just remove the link. The ideal solution is rename this page to tools but also create a redirect in cloudflare to make sure all call to implementations end up in tools.

aialok commented 4 months ago

The implementations url is probably being used from hundreds of sites se we can't just remove the link. The ideal solution is rename this page to tools but also create a redirect in cloudflare to make sure all call to implementations end up in tools.

@benjagm, yes, this is the good to go but cloudflare work will be done by you only. Additionally, I noticed a few typos on the "Tools" page. I think Instead of "implementation," we need to use "tools" everywhere.

Screenshot from 2024-03-01 15-19-03 Screenshot from 2024-03-01 15-18-32

AdityaSingh-02 commented 4 months ago

The implementations url is probably being used from hundreds of sites se we can't just remove the link. The ideal solution is rename this page to tools but also create a redirect in cloudflare to make sure all call to implementations end up in tools.

@benjagm, Yes I completely agree with you, changing the route is not an Ideal Solution since many sites/clients must be using /implementations URLs, the possible solution is fix the page content and change it from tooling to implementations

And I am not sure but implementations page needed a redesign to improve UX https://github.com/json-schema-org/website/issues/160

@benjagm I was Wondering if I could work on this issue.🚀

divyaxdv commented 4 months ago

@benjagm, Yes I completely agree with you, changing the route is not an Ideal Solution since many sites/clients must be using /implementations URLs, the possible solution is fix the page content and change it from tooling to implementations

And I am not sure but implementations page needed a redesign to improve UX #160

@benjagm I was Wondering if I could work on this issue.🚀

@AdityaSingh-02 ,changing the content of the page from tool to implementation is not viable i guess, I dont think that is how this should be proceeded as the implementation page has been updated to Tools knowingly. The solution suggested by @benjagm is ideal but cloudfare work can be done by him only.

benjagm commented 4 months ago

@AdityaSingh-02 @divyaxdv . We will need to review the in the whole site the usage of implementations to adopt the new term tools and we all of that is done, well proceed with:

officeneerajsaini commented 4 months ago

It issue not only occur in mobile it also occur in any other devices because we try to get request from a route that not exits so , we need to make changes in route and also need to make a redirect link so if someone try to get request on "/implementations" route it will redirect to "/tools" @aialok

@benjagm Yeah, I already mentioned that. However, we need to carefully change the route. We need to check every link to ensure they work properly because there are a lot of links.

github-actions[bot] commented 1 month ago

Hello! :wave:

This issue has been automatically marked as stale due to inactivity :sleeping:

It will be closed in 180 days if no further activity occurs. To keep it active, please add a comment with more details.

There can be many reasons why a specific issue has no activity. The most probable cause is a lack of time, not a lack of interest.

Let us figure out together how to push this issue forward. Connect with us through our slack channel : https://json-schema.org/slack

Thank you for your patience :heart: