json-schema-org / website

JSON Schema website
https://json-schema.org
Other
39 stars 121 forks source link

🐛 Bug: Logo color is incorrect on initial load in dark mode #756

Open AdityaBhate opened 1 month ago

AdityaBhate commented 1 month ago

Describe the bug

When visiting the website for the first time, the default theme is dark mode, but the logo color is black instead of white. This issue is resolved when toggling the theme switcher (light/dark mode).

Steps To Reproduce

  1. Visit the website for the first time (ensure no previous theme settings are stored).
  2. Observe the logo color in dark mode.
  3. Toggle the theme switcher to light mode and back to dark mode.
  4. Observe the logo color changes to white correctly.

Expected Behavior

The logo should be white on the initial load when dark mode is the default theme.

Screenshots

Initial Load (chrome, incognito) image


After Toggling the to Light Mode and then to Dark Mode ezgif-5-6862d1b9d8

Device Information [optional]

- OS: Windows 11
- Browser: Chrome
- version: 125.0.6422.142 (Official Build) (64-bit)

- Browser: Firefox
- version: Version 126.0.1 (64-bit)

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

Yes

github-actions[bot] commented 1 month ago

Welcome to the JSON Schema Community. We are so excited you are here! Thanks a lot for reporting your first issue!! 🎉🎉 Please make sure to take a look to our contributors guide if you plan on opening a pull request. For more details check out README.md file.

AdityaBhate commented 1 month ago

Assign me this issue, I would like to work on this

JeelRajodiya commented 3 weeks ago

Hi @AdityaBhate. This issues has been resolved in pull request #735