json-schema-org / website

JSON Schema website
https://json-schema.org
Other
67 stars 174 forks source link

Enhancement: Replace <img> tags with Next.js Image Component #824 #997

Open 29deepanshutyagi opened 1 month ago

29deepanshutyagi commented 1 month ago

This PR refactors several img tags throughout the project to utilize the Image component provided by Next.js.Replaced img tags with Image components

changes are pushed through check branch

issue #824 , kindly check it

github-actions[bot] commented 1 month ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 82030a98215bf0f43bba524fa1709c1a5d45726f
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9899bc7) to head (82030a9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #997 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 10 10 Lines 373 373 Branches 94 94 ========================================= Hits 373 373 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

29deepanshutyagi commented 1 month ago

@benjagm all requested changes are implemented, kindly check it

29deepanshutyagi commented 1 month ago

@benjagm kindly check it

DhairyaMajmudar commented 4 weeks ago

@29deepanshutyagi there are still some comments left to be resolved, can you pls. have a look on them

29deepanshutyagi commented 4 weeks ago

@29deepanshutyagi there are still some comments left to be resolved, can you pls. have a look on them

yeah will commit those changes soon

29deepanshutyagi commented 3 weeks ago

kindly review it @benjagm @DarhkVoyd

DhairyaMajmudar commented 1 week ago

@29deepanshutyagi Great progress!! just small fixes and we are good to go 🚀

29deepanshutyagi commented 5 days ago

,> @29deepanshutyagi Great progress!! just small fixes and we are good to go 🚀

but i had already set the width and height according to their corresponding tailwind class value there previously