jsonMartin / readwise-mirror

MIT License
53 stars 12 forks source link

feat: :sparkles: hot-reload settings after sync #42

Closed johannrichard closed 6 months ago

johannrichard commented 7 months ago

readwise-mirror is currently unaware if an Obsidian sync is implemented, notably resulting in ambiguities regarding its own sync status if a Readwise sync happened elsewhere later (or earlier, but unsynced) than locally.

This proposal implements "onExternalSettingsChange" to reload the settings and update the Status according to the last successful external sync.

I am not entirely sure this is strictly necessary. But generally speaking would consider it good practice to reload the settings if changed elsewhere and pushed through any kind of Obsidian sync. This keeps the state of the Vault and of the Readwise sync in sync.

Please note:

For clarity:

jsonMartin commented 6 months ago

LGTM 👍🏼🚀