search

jsonapi-suite / jsonapi_compliable

MIT License
20 stars 35 forks source link

Fix sidepost validation silently failing #140

Closed seocahill closed 5 years ago

seocahill commented 5 years ago

Sidepost Child A and Child B on Parent, (method: ‘update’)

If Child A is invalid and Child B is valid I get 200 and the fully patched response for all models, although Child A will not in fact be persisted.

If I remove Child B (the valid one) and sidepost again I get the expected 422 and an errors hash.

This fix is copied from https://github.com/graphiti-api/graphiti/issues/38

richmolj commented 5 years ago

@seocahill looks great, but lets make sure to add the passing tests before merging.

seocahill commented 5 years ago

apologies for the delay @richmolj - should be good to go now.

richmolj commented 5 years ago

Thanks @seocahill! Released in 0.11.32