search

jsonapi-suite / jsonapi_compliable

MIT License
20 stars 35 forks source link

allowing for extension of Scoping::Filter class #74

Closed amitsuryavanshi closed 6 years ago

amitsuryavanshi commented 6 years ago

This change will allow someone to extend filtering classes like sonapiCompliable::Scoping::DefaultFilter, JsonapiCompliable::Scoping::Filter, JsonapiCompliable::Scoping::Sort, etc. for any additional or modified functionality.

klobuczek commented 6 years ago

+1 I have had similar problem in the past. Sometimes it is difficult to extend jsonapi_suite. Without such a refactoring you have to duplicate the entire apply_scoping method and thus become much more fragile and missing future extensions.

richmolj commented 6 years ago

What's an example of what you would do with a different filter class?

amitsuryavanshi commented 6 years ago

@richmolj as per our discussion on slack, I have updated the PR. Thanks.

richmolj commented 6 years ago

Released in 0.11.18