search

jsonapi-suite / jsonapi_compliable

MIT License
20 stars 35 forks source link

Add ability to require a filter to be provided #88

Closed Dishwasha closed 6 years ago

Dishwasha commented 6 years ago

I should be allowed to require a consumer to provide one or more filters to prevent cart-blanche querying to the API.

richmolj commented 6 years ago

This looks great and I really appreciate that some thought went into the specs. The only thing missing, I think, is I thought we were going to make this a proc so you could do this based on user auth?

I think we can still merge without supporting procs, but maybe you wanted to take a crack at it?

Dishwasha commented 6 years ago

Added ability for filter to be required based on evaluation of proc. Please let me know what you think of implementation and tests.

richmolj commented 6 years ago

:shipit: 👏 LGTM! Thanks for this ❤️