Closed tchapi closed 1 year ago
@tchapi yes, I would be willing
is the doc in the same repo?
who manges/pays for/supports the jsonform playground website, and how do updates/examples get added/removed there
is the doc in the same repo?
Everything is in this repo on Github, there's nothing else.
who manages/pays for/supports the jsonform playground website
This is Github Pages, directly from the master
branch of this repo. It's free. There is no maintenance or hosting involved.
how do updates/examples get added/removed there
It's in the playground folder
ok, thanks
i see I cannot set labels on issues..
Should be good now
I have a wiki update for #411 , and I made a separate branch.. how can I expose it for any review?
seems it master or nothing.. I will post that to the issue I suppose
Yes, the wiki is not versionned (as in git
) but it's revisioned (here) so you're safe
thx.. posted in original issue.. will wait a little
I think we should merge PRs 414 and 422
at what point do u decide to refresh npmjs lib? and how? I don't have any libs there
I merged #422.
For #414, I think it would be better to update the whole optional dependency ...
sorry don't understand the dependency thing,
got it now, didn't look where the file came from..
shouldnt all these be in a package,json dependencies list.. I don't know where to get them, and a post install script could move them/link them where they need to be.
jsv.js from github project (also 10 yrs old) isn't as big as the one here.. (by half)
I'm all in favour of putting it in package.json
, but jsonform doesn't use any package dependency manager yet (like yarn or npm). This would be a good thing to add but it's not straightforward I think
can u guide me where the components come from/should come from. I see the jQuery stuff
jsv seems soooo different and has dependencies
jsv is here: https://github.com/garycourt/JSV/commits/master The version we use is 0aa11852537069b0830569ef1eab11a36b65b3ab - you can pin the dependency to this specific commit if ever it's not possible to update (I doubt so)
thx. I also have trouble w the jQuery plugins. every time I select download I get taken to jQuery download, which doesn't provide these separated out in the downloaded zip
Can you find them on npm? I'd be easier
didn't look there!
did we want to try for bootstrap 5?
how does test work?
did we want to try for bootstrap 5?
Yes sure (see https://github.com/jsonform/jsonform/issues/364 for instance) but I have no time on my hands to do so
how does test work?
It's only old visual tests in https://github.com/jsonform/jsonform/blob/master/tests/index.html โย they're not really useful anymore I suppose
can u write me two or three paragraphs on what u think the work is, and I can start. not asking u to do it.
my email is my userid at gmail
ah, i see.. I Have never produced a production web site before so haven't investigated using any kind of framework, classes, styles, etc.. and i didn't pay attention to the reasons why there were specific classes on specific elements
so in some cases we can replace the classes with the new (form-group), and test for impacts and in some cases classes/plugins went away.. (dropdown) from the bootstrap core (v5)
and in some cases classes/plugins went away.. (dropdown) from the bootstrap core (v5)
It's included, you just have to include popper.js with it: see https://getbootstrap.com/docs/5.0/components/dropdowns/
ok, i think the strategy should be migrate to V4, then to V5.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Was the update to V5 ever done?
no.
That's sad. Before I waste time hacking my way with the upgrades, and do a PR, is there a fork that has the upgrades?
not that I am aware of.. I was working on it, but never got done.. now swamped with other stuff
Oh okay. Did you have an opportunity to look at what was suggested on the fork on issue #401 ? I could start by upgrading using those suggestions
I saw them, but did not evaluate them at the time I was starting to update ..
some look awesome, some I'm not sure what they mean..
so net, no
I am going to jump Bs4 and go straight to Bs5. Since that's where I need to use the project on. Can we do that on a branch that I can be pushing PRs to?
yes, use the upgrades branch, just created
Thanks!
Well, it seems nothing is broken yet apart from the UI looking ugly but functional. What do you feel about the following:
seems reasonable..
:wave: Hi all contributors,
Unfortunately lately I haven't had the bandwidth to look at issues / pull requests and my day-to-day job is taking too much time. Also, I have little interest to put hours into this library as I'm not using it anymore.
@sdetweil, would you be interested in taking ownership of the maintenance of this library ? I've created an organization so it's easy to add you to it with the correct merge rights.
Thanks ๐๐ผ