search

jsongraph / json-graph-specification

A proposal for representing graph structure (nodes / edges) in JSON.
http://jsongraphformat.info/
Other
449 stars 35 forks source link

Transition tests to python #46

Closed ArSn closed 3 years ago

ArSn commented 3 years ago

As discussed in #45 the wish arose to transition the tests to python, which I did here.

Note that checking of the JGF-schema itself is done implicitly by the python jsonschema package when calling validate and therefore there is not a dedicated test for it. The other reason there is no dedicated test is that I did not find a way to reliably do that with jsonschema (the python package).

I also removed all travis integration in favor of github actions, since travis has a huge build queue for linux builds and is sadly nowhere near realtime anymore.

All obsolete code (ruby code for the tests, travis-config) was removed as well.

P.S.: The status badge in the readme will only show once the workflow ran on the official repo. It will look like this: Run tests.

Let me know if you want any changes, I'll be happy to do them! (P.S.: This is my first time really doing anything in python so please don't slap me if you find anything weird :D)

The docker-compose.yml is just for ease of local development, so one can just do docker-compose up and the deps are installed and the tests are ran on python.

ArSn commented 3 years ago

I just noticed the evidence of the workflow actually running is not in this PR, so you can have a looksie over here: https://github.com/ArSn/json-graph-specification/runs/1421157352?check_suite_focus=true

Its pretty similar to what travis did, just native to github.

wshayes commented 3 years ago

Looks great! Thanks!