json schema validation is fails on empty graph

[schaumb]

Json schema fails on empty graph.

The python testcase is missing. The https://www.jsonschemavalidator.net/ and the python validator are shows the error.

[wshayes]

Not sure I'm following - it should fail on an empty graph object as there are required properties in the graph object.

Are you saying it should not fail? or that we have a test that is passing that should fail?

[schaumb]

Schema: https://github.com/jsongraph/json-graph-specification/blob/ce5ed4007c61df23dd0835094a7b69364ab445d9/json-graph-schema_v2.json

Graph:

Examples

Additional examples empty single graph

{
  "graph": {}
}

The documentation says this is the empty graph representation. The schema is failing on this graph, because oneOf matches on multiple subschema (see: img).

This empty graph is not tested in the test directory.

[wshayes]

Ah - thanks - I’ll need to update the documentation.

On Mar 23, 2021, at 10:03 AM, Bela Schaum @.***> wrote:

Schema: https://github.com/jsongraph/json-graph-specification/blob/ce5ed4007c61df23dd0835094a7b69364ab445d9/json-graph-schema_v2.json https://github.com/jsongraph/json-graph-specification/blob/ce5ed4007c61df23dd0835094a7b69364ab445d9/json-graph-schema_v2.json Graph:

Examples

Additional examples empty single graph

{ "graph": {} } The documentation says this is the empty graph representation. The schema is failing on this graph, because oneOf matches on multiple subschema (see: img).

This empty graph is not tested in the test directory.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jsongraph/json-graph-specification/issues/53#issuecomment-804928518, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACZF53ZNRPMVPR7I4BPP7TTFCNSNANCNFSM4ZT565JA.