search

jsonkao / react-scrollama

Simple scrollytelling with the IntersectionObserver in React.
https://jsonkao.github.io/react-scrollama
MIT License
390 stars 30 forks source link

Updating dependencies #90

Closed fschwander closed 2 years ago

fschwander commented 2 years ago

updated peer dependencies to react 18, updated dependencies of react-scrollama and example app and minor fix for missing default value

jsonkao commented 2 years ago

Sorry I got to this late Fabian. Have you tested that this works with old versions of React? (Particularly the react-dom/client import — I haven't coded React in a while.) Speaking of not coding React for a while, I'm thinking about creating an issue reaching out to past collaborators if they'd be interested in becoming maintainers of this library as I don't really code in React anymore…

fschwander commented 2 years ago

I have testet your library on React 16 an 17 and your library still worked very well. And thanks for pointing out the react-dom/clinet-part: since this is only an update for your example app, your actual library won't be affected by the changes. Therefore, developers who are working with React 16 and 17 still can usereact-scrollama.

But as you pointed out correctly, the example app from now on only runs on React 18 and is not backwards compatible.

Speaking of your library: I would be happy to become a maintainer of react-scrollama. We will use scrolly telling articles in our news portal on a regular basis and it would be fun to collaborate. :)

jsonkao commented 2 years ago

Sounds good! I will merge.

And that's great news! I would love for you to help maintain the library. Will create a formal roll-call among past contributors later today, and then add anyone interested to the repo in the next few days. Thanks so much.