search

jsonkenl / xlsxir

Xlsx parser for the Elixir language.
MIT License
215 stars 85 forks source link

Regression in Erlang OTP 27.1 #128

Open fishtreesugar opened 2 months ago

fishtreesugar commented 2 months ago

In the pull request at https://github.com/erlang/otp/pull/8537, specifically in commit https://github.com/erlang/otp/commit/8d537f5, the CWD is rebuilt using filename:join/2. However, dest_path was not converted from binary to charlist: https://github.com/jsonkenl/xlsxir/blob/4dbebf2eec01ee661d21d78d3ad5b70a91c3339a/lib/xlsxir/unzip.ex#L153-L154 As a result, filename:join/2 returns a binary filename that fails to concatenate with TrailingSlash, which is a charlist: https://github.com/erlang/otp/blob/94d3cd6/lib/stdlib/src/zip.erl#L2330

neilberkman commented 2 months ago

Just came here to report the same issue!