search

jsonkenl / xlsxir

Xlsx parser for the Elixir language.
MIT License
215 stars 85 forks source link

Cleanup worksheet from ets on close #37

Closed AlexKovalevych closed 7 years ago

AlexKovalevych commented 7 years ago

Except tabs and trailing spaces, the fix is in Xlsxir.Worksheet module. Right now, even if you run 

Xlsxir.close(id)

the table won't be deleted, cause id parameter is not passed to alive? function. This commit fixes such issue.

jsonkenl commented 7 years ago

Another great catch. Thank you @AlexKovalevych. I'll add this to the next release.

AlexKovalevych commented 7 years ago

@kennellroxco cool, btw, when do you plan the next release?

jsonkenl commented 7 years ago

I'm off of work next week for the holidays, so I'll add this with a couple other minor changes I need to make and release 1.4.1. I'll let you know once it's updated on Hex.