search

jsonkenl / xlsxir

Xlsx parser for the Elixir language.
MIT License
215 stars 85 forks source link

Fix ConvertDate.from_serial using :calendar #64

Closed sudrao closed 7 years ago

sudrao commented 7 years ago

The date 2021-11-30 fails to be properly converted from Excel. A test case is added for this date.

Fix is to use gregorian days since 1900 and :calendar module.

jsonkenl commented 7 years ago

Thanks @sudrao, your fix is much better than my original implementation.