search

jsonkenl / xlsxir

Xlsx parser for the Elixir language.
MIT License
212 stars 83 forks source link

Xlsxir.get_info() function now has sheet name. #82

Closed hongseokyoon closed 5 years ago

hongseokyoon commented 5 years ago

The function returns sheet name as a name property like bellow.

iex(1)> {:ok, tid} = Xlsxir.multi_extract("./test/test_data/test.xlsx", 0)
{:ok, #Reference<0.1845515270.3329884163.127973>}
iex(2)> Xlsxir.get_info(tid)
[rows: 1, cols: 5, cells: 5, name: "Sheet1"]
iex(3)>
getong commented 5 years ago

This feature is very good, @jsonkenl do you have time to review it?

jsonkenl commented 5 years ago

My apologies for the delay. I'll try to get this reviewed before the end of the week. I'm needing to do a release anyway as it's been a while. Thanks!

CharlesOkwuagwu commented 4 years ago

@jsonkenl In several cases the sheet-name may be known ahead of time, but not the index. Would you be open to an option where multi_extract/5 can take either an index or sheet-name. For Example: {:ok, tid} = Xlsxir.multi_extract("./test/test_data/test.xlsx", "Sheet1")