jsonmaur / jumpsuit

MIT License
1.39k stars 74 forks source link

Added webpack conf for generating UMD JS file #80

Closed hugochinchilla closed 7 years ago

hugochinchilla commented 7 years ago

Generates a UMD file which can be used to experiment with jumpsuit in Codepen or similar services.

Codepen example

TODO:

tannerlinsley commented 7 years ago

Also, by publishing to npm it's automatically published to npmcdn.com.

tannerlinsley commented 7 years ago

Awesome. I think we'll also need to exclude jumpsuit.min.js from github, but add it to the files section of package.json so it gets put in the npm distribution.

hugochinchilla commented 7 years ago

lib is already excluded in .gitignore and already added to package.json, I think it's not necesary to make any more changes

tannerlinsley commented 7 years ago

Oh I meant including the umd in the package.json files section. Is that already there? On Sun, Feb 26, 2017 at 9:16 AM Hugo Chinchilla Carbonell < notifications@github.com> wrote:

lib is already excluded in .gitignore and already added to package.json, I think it's not necesary to make any more changes

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/jumpsuit/jumpsuit/pull/80#issuecomment-282566881, or mute the thread https://github.com/notifications/unsubscribe-auth/AFUmCU4G278cVw4b3SzqGnM1mRP2IEeVks5rgaVigaJpZM4MLLnx .

hugochinchilla commented 7 years ago
  "files": [
    "assets/",
    "bin/",
    "lib/",
    "jumpsuit.js",
    "LICENSE",
    "README.md"
  ],

as far as I understand all files in lib are added, the webpack bundle is lib/jumpsuit.min.js so it should be added as well.

tannerlinsley commented 7 years ago

Excellent!