search

jsonnet-libs / k8s

Code generator for Jsonnet Kubernetes libraries.
Apache License 2.0
171 stars 98 forks source link

feat: Add 'runner scale sets' to actions-runner-controller #340

Closed hamishforbes closed 1 year ago

hamishforbes commented 1 year ago

This one is a bit of an awkward update. I'm not convinced this is the best way so happy to change it

The actions-runner-controller has been adopted by GitHub officially, along with a new 'mode'. Which is actually a completely independent set of CRDs and controllers, but its all in the same repo. It's not clear if there will be any significant further development on the 'legacy' mode either.

See the release announcement here: https://github.com/actions/actions-runner-controller/discussions/2775

I've removed all but the last 2 of the 'legacy' versions and just added the new CRDs as 0.4.

We could make this a new lib, but as always, naming is the hardest bit. Given the new 'mode' is still called the Actions Runner Controller i'm not sure what else to call it and renaming the existing lib to 'actions-runner-controller-legacy' or something will break existing uses of the lib.

hamishforbes commented 1 year ago

👍 Can we merge this then?

xvzf commented 1 year ago

It's in, sorry for the delay @hamishforbes !

hamishforbes commented 1 year ago

It's in, sorry for the delay @hamishforbes !

Thanks! I was on holiday anyway ;)