changeset-bot[bot]
commented
4 months ago 🦋 Changeset detected
Latest commit: 8e00addd5dadca151639b455c2ea7cdb5c4e3dc1
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type | | ---------------------- | ----- | | codemirror-json-schema | Patch |Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
netlify[bot]
acao
Improvements to completion logic (mainly for top level). In true TDD fashion, I'm fairly confident with the changes given the tests are all passing.
Added additional tests for
I wanted to also work on the "include value completions for boolean" test case but there's a bit extra work (when completing the property value and the node used for the completion is different from the original node passed in to
getValueCompletions(), we also need to figure out the correctfromandtovalues for the completion context, so that applying the completion replaces the correct things, otherwise it will replace the original node which may not be what we want) to be done to get it working as expected, so decided to tackle part of it but leave it commented out for now.