jsonnext / codemirror-json-schema

A JSONSchema enabled mode for codemirror 6, for json4 and json5, inspired by monaco-json
https://codemirror-json-schema.netlify.app
MIT License
61 stars 11 forks source link

set up json5 completion demo and handle edge cases #35

Closed acao closed 1 year ago

acao commented 1 year ago

this adds working completion in a lot of cases, but there are some broken edge cases

here are some examples of the working completions across json4 and json5, both improvements and existing completion-examples.webm

Todo:

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 6a4d80960c9b17bbe9cccc5de090055bce0781e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for codemirror-json-schema ready!

Name Link
Latest commit 6a4d80960c9b17bbe9cccc5de090055bce0781e5
Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/64bbbfc050bbcf00082865b8
Deploy Preview https://deploy-preview-35--codemirror-json-schema.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

acao commented 1 year ago

closing because #36 is the real way to do this, and I will move the hover fixes into their own PR