Closed imolorhe closed 11 months ago
Latest commit: 44b22e377f0ef7e1be4d35a9a2f2b2f5feda55ac
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Name | Link |
---|---|
Latest commit | 44b22e377f0ef7e1be4d35a9a2f2b2f5feda55ac |
Latest deploy log | https://app.netlify.com/sites/codemirror-json-schema/deploys/64bf5eb7425e50000711bd3d |
Deploy Preview | https://deploy-preview-45--codemirror-json-schema.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@imolorhe so exciting!! of course it's as simple as adding this codemirror api. i noticed you'd set up the logic already, exciting this is all we need to get it working!
Feel free to merge and release it wheneve you like, I will be adding unit tests this week as soon as I get a chance
It appears to be working for objects like publishConfig
, but for some reason it doesn't work for `dependencies' and similar, I wonder why? I will add more tests after interviews today and see what tweaks we need to make
going to go ahead and merge this, and add a bunch of test coverage tonight!
oops, forgot a changeset
applied snippetCompletion to property completions
https://github.com/users/acao/projects/1/views/1?pane=issue&itemId=33580826