jsonnext / codemirror-json-schema

A JSONSchema enabled mode for codemirror 6, for json4 and json5, inspired by monaco-json
https://codemirror-json-schema.netlify.app
MIT License
57 stars 9 forks source link

applied snippetCompletion to property completions #45

Closed imolorhe closed 11 months ago

imolorhe commented 12 months ago

applied snippetCompletion to property completions

Screenshot 2023-07-25 at 7 33 59 AM

https://github.com/users/acao/projects/1/views/1?pane=issue&itemId=33580826

changeset-bot[bot] commented 12 months ago

⚠️ No Changeset found

Latest commit: 44b22e377f0ef7e1be4d35a9a2f2b2f5feda55ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 12 months ago

Deploy Preview for codemirror-json-schema ready!

Name Link
Latest commit 44b22e377f0ef7e1be4d35a9a2f2b2f5feda55ac
Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/64bf5eb7425e50000711bd3d
Deploy Preview https://deploy-preview-45--codemirror-json-schema.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

acao commented 12 months ago

@imolorhe so exciting!! of course it's as simple as adding this codemirror api. i noticed you'd set up the logic already, exciting this is all we need to get it working!

acao commented 12 months ago

Feel free to merge and release it wheneve you like, I will be adding unit tests this week as soon as I get a chance

acao commented 12 months ago

It appears to be working for objects like publishConfig, but for some reason it doesn't work for `dependencies' and similar, I wonder why? I will add more tests after interviews today and see what tweaks we need to make

acao commented 11 months ago

going to go ahead and merge this, and add a bunch of test coverage tonight!

acao commented 11 months ago

oops, forgot a changeset