jsonnext / codemirror-json-schema

A JSONSchema enabled mode for codemirror 6, for json4 and json5, inspired by monaco-json
https://codemirror-json-schema.netlify.app
MIT License
63 stars 12 forks source link

failing case for json4 completion #54

Closed acao closed 1 year ago

acao commented 1 year ago

this test will fail on purpose, we need to make it green!

and also ensure the fix works in deeply nested objects - for example, this case should not cause it to offer completions for any parent object

this seems to be something to work from: image

from what I can tell, this fixes it?

image

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: c4546c0a9c1c6b013e638804b844c5d14eaabb2a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for codemirror-json-schema ready!

Name Link
Latest commit c4546c0a9c1c6b013e638804b844c5d14eaabb2a
Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/64cf53c3fff90a00087aa72d
Deploy Preview https://deploy-preview-54--codemirror-json-schema.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.