search

jsonnext / codemirror-json-schema

A JSONSchema enabled mode for codemirror 6, for json4 and json5, inspired by monaco-json
https://codemirror-json-schema.netlify.app
MIT License
57 stars 9 forks source link

remove json-schema #65

Closed AlexErrant closed 8 months ago

AlexErrant commented 9 months ago

It is unused (I think, since pnpm build and pnpm test pass for me locally) and more importantly Dependabot is yowling at me that 0.2.3 has a "Critical" CVE, (which I don't mind talking about publically because you don't use this dep).

image

changeset-bot[bot] commented 9 months ago

🦋 Changeset detected

Latest commit: 4d0efa533e7c40f366cee8fc1a8be94604174535

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------- | ----- | | codemirror-json-schema | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 9 months ago

Deploy Preview for codemirror-json-schema ready!

Name Link
Latest commit 4d0efa533e7c40f366cee8fc1a8be94604174535
Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/651485f2d3106e000752e719
Deploy Preview https://deploy-preview-65--codemirror-json-schema.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

acao commented 8 months ago

strange, it must still be resolving the imports from another package shipping with this dependency. I will look into this some more!

acao commented 8 months ago

@AlexErrant in #70 I managed to upgrade to the latest version. I would like to keep it as it is a type dependency. thanks for this and for reporting the issue!