jsonnext / codemirror-json-schema

A JSONSchema enabled mode for codemirror 6, for json4 and json5, inspired by monaco-json
https://codemirror-json-schema.netlify.app
MIT License
57 stars 9 forks source link

Fix a few bugs with top level schema definitions #74

Closed acao closed 1 month ago

acao commented 8 months ago
changeset-bot[bot] commented 8 months ago

⚠️ No Changeset found

Latest commit: 22c47a654fb184f05b52e50510facd99c38a089e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 8 months ago

Deploy Preview for codemirror-json-schema ready!

Name Link
Latest commit 22c47a654fb184f05b52e50510facd99c38a089e
Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/656d1da996a4240008a7126e
Deploy Preview https://deploy-preview-74--codemirror-json-schema.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

acao commented 1 month ago

@imolorhe from what i can tell it is because our getPointer method skips the object root itself

imolorhe commented 1 month ago

@acao I was able to get it working without touching getPointer. Just touching the completion logic, and all tests are passing!

imolorhe commented 1 month ago

Since I'm on it, want to tackle a few other test cases before creating a PR

acao commented 1 month ago

@imolorhe awesome work! yeah I saw that you added these test cases and todos for the ones left. was awesome to see so many more standard schemas working! closing this for now as the next steps are already in the TODO comments