Closed acao closed 1 month ago
Latest commit: 22c47a654fb184f05b52e50510facd99c38a089e
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Name | Link |
---|---|
Latest commit | 22c47a654fb184f05b52e50510facd99c38a089e |
Latest deploy log | https://app.netlify.com/sites/codemirror-json-schema/deploys/656d1da996a4240008a7126e |
Deploy Preview | https://deploy-preview-74--codemirror-json-schema.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@imolorhe from what i can tell it is because our getPointer method skips the object root itself
@acao I was able to get it working without touching getPointer. Just touching the completion logic, and all tests are passing!
Since I'm on it, want to tackle a few other test cases before creating a PR
@imolorhe awesome work! yeah I saw that you added these test cases and todos for the ones left. was awesome to see so many more standard schemas working! closing this for now as the next steps are already in the TODO comments
allOf
bug #73 and #69