jsonnext / codemirror-json-schema

A JSONSchema enabled mode for codemirror 6, for json4 and json5, inspired by monaco-json
https://codemirror-json-schema.netlify.app
MIT License
56 stars 9 forks source link

improve bundling, demo and hover rendering #87

Closed acao closed 1 month ago

acao commented 4 months ago
changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: b149588d38a80a326d23d6da5860b00271915019

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 4 months ago

Deploy Preview for codemirror-json-schema failed.

Name Link
Latest commit b149588d38a80a326d23d6da5860b00271915019
Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/65da1b2749831b0008d67906
acao commented 1 month ago

@imolorhe great point - I looked up the source to cm6-buildhelper and they also use moduleResolution: node so we should match theirs, yeah

acao commented 1 month ago

@imolorhe this means disabling top level await, which also means we must instantiate the shiki renderer with an async iife :/

acao commented 1 month ago

forgot changeset for this 😆