search

jsonnull / electron-trpc

Build type-safe Electron inter-process communication using tRPC
https://electron-trpc.dev/
MIT License
267 stars 26 forks source link

Allow closing active subscriptions #174

Closed lamualfa closed 6 months ago

lamualfa commented 1 year ago

Since this PR https://github.com/trpc/trpc/pull/4136, TRPC Client allows users to close active subscriptions.

Closing an active subscription using the current electron-trpc version will lead us to this error https://github.com/trpc/trpc/discussions/4060#discussioncomment-6791795

This PR allows for the closing of active subscriptions. It removes unnecessary code related to tracking the completion of operations and simplifies the logic for error handling and completion. The changes ensure that the observer is properly notified when an operation is complete or when an error occurs.

Generated using OpenSauced.

netlify[bot] commented 1 year ago

Deploy Preview for electron-trpc ready!

Name Link
Latest commit e8247c1f9ea0752b3f262abb45c972cea15dabb8
Latest deploy log https://app.netlify.com/sites/electron-trpc/deploys/64e4c62a4d2d960008264ffd
Deploy Preview https://deploy-preview-174--electron-trpc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.