refactor: Remove dead block of code

jsonrainbow / json-schema

PHP implementation of JSON schema. Fork of the http://jsonschemaphpv.sourceforge.net/ project

MIT License

3.53k stars 351 forks source link

refactor: Remove dead block of code #710

Closed DannyvdSluijs closed 4 months ago

DannyvdSluijs commented 7 months ago

Based on the original PR (#641) from Markus Staab it was found the incorrect order of arguments to be in a dead piece of code. The strpos-call was added in ffc856db on 18/02/2016 whereas in 6474265b on 03/03/2016 the calling code of the validateDateTime with an format argument containing an u was removed making this check void. So removing the code block would be best, hence this PR.

DannyvdSluijs commented 4 months ago

However, I don't see a test result for this PR; does CI run for PRs on this repo?

I’ve seen this on other PRs in this repo as well. I’ll keep an eye out for this issues. For now I’ve amended the commit, creating a new commit hash which has started the pipeline.

dafeder commented 4 months ago

Well again a little insecure still about approving being so new to the codebase itself but lgtm?