search

jsonrainbow / json-schema

PHP implementation of JSON schema. Fork of the http://jsonschemaphpv.sourceforge.net/ project
MIT License
3.53k stars 350 forks source link

Re-evaluate icecave dependency #753

Open W0rma opened 1 day ago

W0rma commented 1 day ago

https://github.com/jsonrainbow/json-schema/pull/518 added the dependency to icecave/parity.

In https://github.com/composer/composer/pull/12039#issuecomment-2229072029 it was recommended to check whether this dependency is really necessary:

At some point we maybe should (re-) evaluate them. Especially the icecave/* seems the odd one out as it is advertised as a A customizable deep comparison library. Which seems unneeded at a quick glance.

I just created this issue to not forget about this evaluation.

DannyvdSluijs commented 1 day ago

Thanks for issue report. Is this something you've already did some investigation into or have some knowledge about? Or is it purely a reminder at this point?