fix: styles and move to handlebars - Githubissues

jsonresume / jsonresume-theme-modern

Prototyping a theming system based off NPM.

https://themes.jsonresume.org/theme/modern

MIT License

14 stars 38 forks source link

fix: styles and move to handlebars #17

Closed SethFalco closed 3 years ago

SethFalco commented 3 years ago

Move from Mustache to Handlebars

Handlebars offers helper methods which can make maintainer the template easier.

Refactored `main.js`

Tidied up the entire file.
Only fetches avatar from Gravatar if basics.image isn't already defined.
No longer remaps social media, just displays the array in the order it was received.

package.json / package-lock.json

Updates all dependencies.
Specifies correct license.
Adds resume-cli as dev dependency for development use.
Adds scripts to build PDF/HTML file.
package-lock.json is intended to be committed.

Template

Fixes HTML in template.
Moves to Handlebars syntax.
Makes many fields optional, like basics.phone and basics.email..
Adds backward compatibility with certain fields such as work.company or basics.firstName and basics.lastName.
Links phone number and email address.
Updates jQuery and Lumen/Bootstrap.

Related Issues

Closes https://github.com/jsonresume/jsonresume-theme-modern/pull/8 - Merge conflicts, this covers the change.
Closes https://github.com/jsonresume/jsonresume-theme-modern/pull/15 - Better fix for Gravatar, and uses Bootstrap 5 instead of 4.
Closes https://github.com/jsonresume/jsonresume-theme-modern/issues/9 - Uses working URL for Bootstrap.

This might not perfect, but should cover 99% of fixing the theme.