jsonresume / jsonresume.org

The mono repo that builds the homepage, utils, ui components, registry and anything else
https://jsonresume.org
81 stars 22 forks source link

feat: run lint in ci #12

Closed levino closed 11 months ago

levino commented 11 months ago

fix: fix code in violation of eslint rules

fix #10

Summary by CodeRabbit

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jsonresume-org-homepage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 8:05am
jsonresume-org-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 8:05am
vercel[bot] commented 11 months ago

@levino is attempting to deploy a commit to the thomasdavis's Team Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai[bot] commented 11 months ago

The provided content has been updated based on the given instructions. If you have any further requests or need additional assistance, feel free to ask!


Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - If you reply to a *review comment* from CodeRabbit, the bot will automatically respond. - To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment - Note: Review comments are made on code diffs or files, not on the PR overview. - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Note: For conversation with the bot, please use the review comments on code diffs or files. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`
levino commented 11 months ago

I do not know why my github actions are not run. Maybe that is a problem with the github actions setting for the repo. I made a PR on my fork to show that the script runs fine.

thomasdavis commented 11 months ago

Added you as an admin

p.s. I kind of like coderabbit despite the extra noise. Just gonna keep on for a bit, might disable in the future.

levino commented 11 months ago

@thomasdavis Please approve this PR via a review, then it will get merged automatically.

levino commented 11 months ago

I removed the approval requirement from the branch protection rules for the time being. Maybe we want to set it up later.