jsonresume / jsonresume.org

The mono repo that builds the homepage, utils, ui components, registry and anything else
https://jsonresume.org
68 stars 18 forks source link

Feature/run prettier in ci #13

Closed levino closed 9 months ago

levino commented 9 months ago

Based on #12

Summary by CodeRabbit

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jsonresume-org-homepage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 8:33am
jsonresume-org-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 8:33am
vercel[bot] commented 9 months ago

@levino is attempting to deploy a commit to the thomasdavis's Team Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai[bot] commented 9 months ago

[!WARNING]

Rate Limit Exceeded

@levino has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 19 minutes and 58 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 613eb35f483c5ec0c71d692b3993227ccc1f3c0e and ab5e0e77e02da42e32c161732a35329856294ad5.

Walkthrough

The changes are primarily cosmetic, focusing on code style and readability improvements across various files. They include the standardization of quote usage in import statements and string literals, formatting adjustments for HTML and CSS, and updates to documentation and markdown files. Additionally, there are minor updates to JavaScript logic and GitHub Actions configurations.

Changes

File Path Change Summary
.github/workflows/ci.yml Updated lint command to include prettier.
.prettierignore, README.md, apps/homepage/..., apps/registry/..., packages/... Standardized quotes from single to double, improved formatting, and updated documentation.
apps/homepage/css/style.css Adjusted CSS transition timings and opacity values.
apps/homepage/_layouts/default.html, apps/homepage/_layouts/post.html Reformatted HTML and JavaScript, added Google tag script.
apps/registry/pages/api/formatters/... Changed export statements and updated string formatting.
apps/registry/pages/api/samples/resume.js, apps/registry/pages/api/schema.js Updated resume object and JSON schema formatting and content.
apps/registry/pages/... Updated import statements, string literals, and inline styles.
packages/jsonresume-theme-standard/src/ui/... Changed import statements to use double quotes.

🐇 Oh code so neat, with quotes aligned,
A rabbit hopped through, with style in mind.
From single to double, the changes we see,
In strings and imports, as tidy as can be.

With each curly brace and tag that's self-closed,
Our rabbit's keen eyes, no detail opposed.
Through GitHub Actions, the linting now tight,
Ensuring the code is a wonderful sight.

So here's to the changes, both big and small,
For cleaner code benefits one and all.
🌟📝🎉


Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - If you reply to a *review comment* from CodeRabbit, the bot will automatically respond. - To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment - Note: Review comments are made on code diffs or files, not on the PR overview. - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Note: For conversation with the bot, please use the review comments on code diffs or files. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`
thomasdavis commented 9 months ago

@levino wow nice effort !