search

jsonresume / jsonresume.org

The mono repo that builds the homepage, utils, ui components, registry and anything else
https://jsonresume.org
68 stars 18 forks source link

enable mac compatibility #27

Closed levino closed 9 months ago

levino commented 9 months ago

Based on #25. The apage theme requires an environment variable LANG to be present, which is not the case on MacOS, but probably only on linux. I think that makes the theme essentially broken and we should remove it, until this issue has been fixed.

Summary by CodeRabbit

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jsonresume-org-homepage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 2:20pm
jsonresume-org-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 2:20pm
coderabbitai[bot] commented 9 months ago

Walkthrough

The changes involve setting up a GitHub Actions workflow for Playwright tests and modifying the API by removing a theme export. The workflow is configured to run tests on an Ubuntu environment, with steps for setup, dependency installation, and test execution. The API change suggests a cleanup or deprecation of a theme.

Changes

File Path Change Summary
.github/workflows/playwright.yml Added a GitHub Actions workflow for Playwright tests.
apps/.../api/formatters/template.js Removed the export of the apage theme.

🐇✨ In the realm of code, where tests play and dart, A workflow's born, a CI art. Themes retreat, as apage departs, In the commit's wake, a new start. 🚀🌟

Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - If you reply to a *review comment* from CodeRabbit, the bot will automatically respond. - To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment - Note: Review comments are made on code diffs or files, not on the PR overview. - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Note: For conversation with the bot, please use the review comments on code diffs or files. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`
thomasdavis commented 9 months ago

Yeah happy to just remove apage