Closed jsantos42 closed 8 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
jsonresume-org-homepage | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 28, 2023 10:47am |
jsonresume-org-registry | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 28, 2023 10:47am |
The change involves a simple text correction within an HTML file. A typographical error in the phrase "Resume Suggestions" has been fixed to enhance clarity and professionalism. The word "precide" was replaced with "precise," ensuring the content is grammatically correct.
File Path | Change Summary |
---|---|
.../homepage/getting-started.html |
Corrected typo from "precide" to "precise" in text content |
🐇✨ In the code, there was a slip, A word not quite right, it caused a blip. Now "precise" stands correct and bright, A rabbit's touch, made the code just right. 🌟📝
@jsantos42 is attempting to deploy a commit to the JSON Resume Team on Vercel.
A member of the Team first needs to authorize it.
@thomasdavis should I ask for clearance to merge to master or should I create a new branch instead?
Hi @jsantos42, I do not understand your question. Could you please elaborate?
I think you are not not a collaborator. So I think you cannot merge to master, right? You committed to the master branch in your fork and then opened a PR, which is fine. Now we just have to accept and merge it, right? Did you want to ask whether or not you should open the PR from a different branch than "master"?
Hi @levino 👋
Now we just have to accept and merge it, right?
I believed so, yes!
Did you want to ask whether or not you should open the PR from a different branch than "master"?
Precisely
Thank you for catching this.
You're welcome! Thank you guys for this awesome project
This is what I think I understand about forking and PRs: It does not matter how you call a branch on a fork. If you would push to this repo, you should use a name other than master
for obvious reasons 😄 (It is impossible to push to master
btw since this branch is protected in this repo). When we merge, we merge the new commits in your branch, not your branch. The branch does not exist outside the scope of your fork so to say. I hope that helps. Cheers.
@jsantos42 thanks Jaoa, you did it correctly! as above, because it is from your own repo, you can use the same branch name. though I would recommend you give it a different name when creating pull requests upstream
Summary by CodeRabbit