search

jsonresume / jsonresume.org

The mono repo that builds the homepage, utils, ui components, registry and anything else
https://jsonresume.org
66 stars 17 forks source link

Feature/improve stackoverflow theme integration #35

Closed levino closed 8 months ago

levino commented 8 months ago

Summary by CodeRabbit

Please note that internal code-level details are intentionally omitted to maintain confidentiality.

coderabbitai[bot] commented 8 months ago

[!WARNING]

Rate Limit Exceeded

@levino has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 41 minutes and 21 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 63c57b7578cdaff261e6da049b7f1f0f5dc9b786 and b0a714e71eba202f8c51ecce4e1adcd4dfefc034.

Walkthrough

The project underwent a series of updates across various configuration files, workflow enhancements, and codebase improvements. ESLint and Prettier configurations were introduced or updated, emphasizing adherence to coding standards. GitHub Actions now includes a new Node.js version and Slack notifications. Storybook and i18n setups were added for UI component documentation and internationalization. New React components were created for a Stack Overflow theme, with Storybook stories to showcase them. Additionally, changes in .gitignore and .npmignore files suggest a cleanup of version control for build artifacts.

Changes

File(s) Summary
.eslintrc.json Added new ESLint configuration.
.github/workflows/release.yml Updated workflow with concurrency, Node.js 16.x, and Slack notifications.
.prettierignore Updated to ignore the dist directory.
apps/registry/.../template.js Refactored theme imports and THEMES object structure.
apps/registry/pages/api/interview.js Changed import order.
packages/eslint-config-custom/next.js Extended ESLint config to include 'next' and disable a rule.
packages/ui/.eslintrc.json Added ESLint config extending "custom/react".
themes/stackoverflow/.eslintrc Introduced "custom/react" ESLint preset.
themes/stackoverflow/.gitignore Updated to ignore various directories and files, except public/profile.jpeg.
themes/stackoverflow/.npmignore Added specific file and directory names to ignore.
themes/stackoverflow/.storybook/... Added new Storybook and i18n configuration files.
themes/stackoverflow/CHANGELOG.md Updated with version changes, features, and fixes.
themes/stackoverflow/README.md Added information on the new jsonresume-theme-stackoverflow-react theme.
themes/stackoverflow/src/... Added new React components and Storybook stories for resume sections.
themes/stackoverflow/.yarnrc.yml Added nodeLinker and yarnPath configurations.
themes/stackoverflow/style.css Updated CSS with styling and responsive design changes.
themes/stackoverflow/types/index.d.ts (Not fully displayed) Presumably updated TypeScript type definitions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - You can reply to a review comment made by CodeRabbit. - You can tag CodeRabbit on specific lines of code or files in the PR by tagging `@coderabbitai` in a comment. - You can tag `@coderabbitai` in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`
vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jsonresume-org-homepage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 9:18am
jsonresume-org-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 9:18am
levino commented 8 months ago

This is a follow up on #32. I did not want to overcomplicate things here, so I am using this to do the actual nitty gritty work.

levino commented 8 months ago

@thomasdavis Please only approve "Ready for review" PRs. I really hope you take a look, once I have finished the PRs because it is always better to have 4 eyes on the things in order not to break stuff or change things that I did not intend to. I might even split this PR up because it is becoming huge and a bit messed about the scope.

thomasdavis commented 8 months ago

No worries, I did have a look at it all. p.s. love it. will wait for "ready for review" next time

changeset-bot[bot] commented 8 months ago

⚠️ No Changeset found

Latest commit: b0a714e71eba202f8c51ecce4e1adcd4dfefc034

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

levino commented 8 months ago

I will try to clean up the git history. Also I want to enable deployment to npm from ci, so I do not have to do it by hand.

thomasdavis commented 8 months ago

oh npm deployment would be hot. trigged by package.json version changes or something else?

levino commented 8 months ago

Merging. Any fallout from this I will mop up later.

thomasdavis commented 8 months ago

@levino so good to have the stackoverflow theme back, great job