Missing themes

[thomasdavis]

This is an dedicated to people who wish to request themes to be added to the hosted registry.

It is linked from the registry when a theme is not found when trying to render.

Note: recently we disabled a bunch of legacy themes from working with the registry. This will unfortunately/regrettably affect users using these themes. They were disabled because their latest versions were to out of date and concerned many critical errors in their code.

I will personally be keeping an eye an out for themes which are still being regularly used on the registry and fixing them as soon as possible.

If you were negatively affect, apologies again, please post the theme you want re-instated.

Currently looking into bringing back:

• onepage
• papirus
• caffeine

[sachsgiri]

please bring back theme called "full"

[thomasdavis]

@sachsgiri I've fixed up the full theme, it should work as it was now.

[clmay]

Here's a vote for onepage! What all is involved in bringing a theme back "online"—are you just opening a PR with dependency updates, or are you forking them into the jsonresume org, or are you just re-enabling them from the registry side, or?

I'd be open to giving it a go on my own and save you some work, if that's worth it; or maybe it's trivial enough that it's not worth trying to explain and you just prefer to get it done. :)

[thomasdavis]

Hey @clmay, I'm a bit busy at the moment so if you wanted to take a stab that would be awesome.

I am just bringing them into the repo, the onepage repo is quite simple -> https://github.com/ainsleyc/jsonresume-theme-onepage

If you just copy what I did here https://github.com/jsonresume/jsonresume.org/commit/7a56ff585ea4e40eedaa2bcb4b6398990c2b03ce

Which just downloads the repo into packages, then get rid of the readFileSync and wrap the styles and template in template literals and import directly.

And also bumping the version of handlebars to latest.

[levino]

We should add a section in the readme or add some other markdown file explaining the procedure and also highlighting the issues of vercel serverless deployment and node fs.

[ObserverOfTime]

So why was my theme disabled? :thinking:

[levino]

Dear @ObserverOfTime please provide a more complete description of your problem. Which theme is "yours"? How do you determine that it is "missing"?

[ObserverOfTime]

52

[miraldo]

It was fantastic to have OnePage back.

[thomasdavis]

@ObserverOfTime thanks for pointing out that elegant does use fs. There is some strange problem I haven't figured out yet, but in short when Vercel deploys the code/themes to it's functionless environments, it doesn't seem to think that a lot of these files are for the bundle, so it skips them. Perhaps because that example is an assets folder it decides to include it. I will further investigate.

@miraldo Sorry about the inconvenience, I've just fixed and re-added the onepage theme to the repo (currently deploying)

[alexanderdavide]

Hey @thomasdavis, I'd love to have onepage-plus back. It made minor changes to onepage I really enjoyed.

I've opened a PR #59. :rocket:

[thomasdavis]

Add dense2col theme https://github.com/hatelamers/jsonresume-theme-dense2col

[skoenig]

Hey, would be nice if you could include the engineering theme.

[levino]

Just FYI, it is not so much about whether or not to include the themes or not. The missing themes are broken due to an outdated source and often a problematic usage of and assumptions about the local file system. So the themes need to be fixed and can only then be included.

[thomasdavis]

@skoenig I've always loved that theme. Unfortunately the new system doesn't support the using of fs.readFileSync in npm templates.

You either need to use a build system or use import to get files in. I could help out writing a PR if you don't have the time. Otherwise checkout the packages/templates folder in this repo to see how other themes have migrated handlebars style themes.

[skoenig]

@thomasdavis Thanks for the hint about the templates, I'll try to find some time to work on making it compatible with the new system in the next few days. At the risk of overlooking something obvious: Is the complete code of a theme supposed to be vendored in this repository here under packages?

[Greg-Bush]

Hello! Could you please add my extension for kendall theme: https://www.npmjs.com/package/jsonresume-theme-kendall-bushmanov

[kasperab]

I just published version 1.0.0 of my theme ”Vitae”, and I would like for it to be included in the registry. Thanks!

[thomasdavis]

This is a beautiful theme to add https://github.com/MoritzBru/jsonresume-theme-reactive

This one too https://github.com/bn3t/resume-ng

Might require some work to export a render function