Closed thomasdavis closed 8 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
jsonresume-org-homepage | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 29, 2023 9:50am |
jsonresume-org-registry | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 29, 2023 9:50am |
The recent updates focus on improving error handling within an API. Error messages have been clarified, and HTTP status codes adjusted to better reflect the nature of the errors. A specific case for a missing theme has been addressed, providing users with a helpful link to report or request themes on GitHub.
File Path | Change Summary |
---|---|
.../[payload].js |
Corrected error message wording, added custom error message for "theme-missing" with a GitHub issue link, and updated HTTP status codes for various errors. |
.../formatters/template.js |
Implemented error handling for missing theme renderer. |
🐇✨ To the code we hop and leap, Errors caught, no more we weep. With messages clear and guide in hand, Our code now speaks, as we had planned. 🌟📜
@levino approval on this one is kinda of urgent
Please see https://github.com/jsonresume/jsonresume.org/issues/38#issuecomment-1831578943 If you get impatient, let me know and I will approve anyhow.
@thomasdavis You can now "override" the branch protection rules and merge as you please. There should be a checkbox with a red warning text just above the "merge button". This is so you do not become blocked if I am absent etc. I suggest to still only use it when it is really necessary ("emergency").
I would also add a test to try to open the site with a non-working theme and see that it returns an error code and check that the message contains expected strings (like "github issue" or something).
@levino good feedback. just merging for now so i can collect the errors of the themes that are missing. but will add the test, and move to a theme request template later today
Fix #38
Summary by CodeRabbit
Bug Fixes
Documentation