search

jsonresume / jsonresume.org

The mono repo that builds the homepage, utils, ui components, registry and anything else
https://jsonresume.org
66 stars 17 forks source link

remove possible name collisions #43

Open levino opened 8 months ago

levino commented 8 months ago

Currently the registry has some special routes like /interview, /jobs etc. We should host these routes on a different domain or stop using the root for the cv generation (e.g. /{GITHUB_USERNAME}) since if someones username would be "jobs" they just could not create a cv.

thomasdavis commented 2 months ago

I'm not sure it's that big of an issue.

Lot's of websites do this e.g. Github, Twitter

Also those pages are re-routed so that only work when in the form of {USERNAME}/interview

levino commented 2 months ago

True, true. But github is in control of the usernames it issues. So nobody can make a user with handle @settings.

Feel free to close this issue.