search

jsonresume / jsonresume.org

The mono repo that builds the homepage, utils, ui components, registry and anything else
https://jsonresume.org
66 stars 17 forks source link

please bring back theme called "full" #46

Closed levino closed 8 months ago

levino commented 8 months ago 
          please bring back theme called "full"

Originally posted by @sachsgiri in https://github.com/jsonresume/jsonresume.org/issues/36#issuecomment-1835834487

levino commented 8 months ago

NPM https://www.npmjs.com/package/jsonresume-theme-full github https://github.com/jackkeller/jsonresume-theme-full#readme

The problem is that the theme is using handlebars@2 which is deprecated and has proven security vulnerabilities. Source code needs to be updated, then we might be able to bring it back.

Do you think you could make a PR for jsonresume-theme-full to update the handlebars dependency @sachsgiri?

thomasdavis commented 8 months ago

fixed in https://github.com/jsonresume/jsonresume.org/pull/47