Closed thomasdavis closed 8 months ago
Latest commit: 53e7f8245d077dfc2ecdce847842a2e16ae6f3b2
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
jsonresume-org-homepage | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Dec 2, 2023 5:38am |
jsonresume-org-registry | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Dec 2, 2023 5:38am |
The project has undergone a theme update, replacing jsonresume-theme-spartacus
with jsonresume-theme-papirus
. This includes the addition of new template strings for various resume sections, the introduction of a new theme with detailed documentation, and updates to the build and linting configurations. Aesthetic changes have been made to the CSS, and unnecessary console logs have been removed. The project's dependencies and build processes have been updated to reflect these changes.
File(s) | Summary |
---|---|
.prettierignore |
Package jsonresume-theme-spartacus replaced with jsonresume-theme-papirus . |
apps/registry/pages/api/formatters/template.js |
Added "papirus" theme to THEMES object. |
packages/jsonresume-theme-full/index.js |
Removed console.log statement. |
packages/jsonresume-theme-papirus/.eslintrc , .stylelintrc |
Added new ESLint and Stylelint configurations. |
packages/jsonresume-theme-papirus/.gitignore , .npmignore |
Updated ignore files for version control and npm. |
packages/jsonresume-theme-papirus/LICENSE |
Added MIT License. |
packages/jsonresume-theme-papirus/README.md |
Introduced "Papirus" theme with development, installation, and usage instructions. |
packages/jsonresume-theme-papirus/config.js |
New module export with paths and names for various directories and files. |
packages/jsonresume-theme-papirus/gulpfile.js |
Added 'default' gulp task definition. |
packages/jsonresume-theme-papirus/index.js , partials/... , resume.js , style.js |
Added new imports, template strings, and styles for the "Papirus" theme. |
packages/.../partials/*.js |
Introduced default export template strings for resume sections like work, education, skills, etc. |
The tests for the PR were failing, it should not have been merged in my opinion. Even if we can "override" the requirements like "1 approval from another person", we should make sure that all checks pass. This particular fail seems to have to do with some turbo
config problem.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Style
Chores
Refactor
Tests
Revert