jsonresume / jsonresume.org

The mono repo that builds the homepage, utils, ui components, registry and anything else
https://jsonresume.org
66 stars 17 forks source link

showcase proper handlebars setup #51

Closed levino closed 8 months ago

levino commented 8 months ago

fix: json-resume-papirus

Summary by CodeRabbit

changeset-bot[bot] commented 8 months ago

🦋 Changeset detected

Latest commit: b20e0e39c55a637c17ef61bf1de44fec0553fbe9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------------- | ----- | | @jsonresume/theme-stackoverflow | Patch | | registry | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jsonresume-org-homepage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 9:46am
jsonresume-org-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 9:46am
coderabbitai[bot] commented 8 months ago

[!WARNING]

Rate Limit Exceeded

@levino has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 3 minutes and 32 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 08df4332f51fdd6dd5733428e889dd8be5cce371 and b20e0e39c55a637c17ef61bf1de44fec0553fbe9.

Walkthrough

The project underwent a series of updates affecting CI configuration, code formatting, dependency management, and the handling of resume themes. The CI pipeline was adjusted for higher concurrency due to a bug, and the code formatter now has more specific rules for certain file types. Dependencies were removed, suggesting a shift in the project's visual themes. Significant changes were made to the jsonresume-theme-papirus package, including new features and refactoring to ES6 syntax, while jsonresume-theme-spartacus saw only minor cosmetic changes.

Changes

File(s) Summary
.github/workflows/ci.yml CI pipeline adjusted for higher concurrency.
.prettierignore, .prettierrc Code formatting rules updated; dependencies removed.
apps/registry/next.config.js New dependency added; webpack config updated for .hbs files.
apps/registry/pages/interview.js Console logs removed; message handling code commented out.
packages/jsonresume-theme-full/README.md Documentation content removed and refactored.
packages/jsonresume-theme-papirus/... Major updates with new features, ES6 syntax, and template additions.
packages/jsonresume-theme-spartacus/... Minor cosmetic changes to README, resume, and style files.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - You can reply to a review comment made by CodeRabbit. - You can tag CodeRabbit on specific lines of code or files in the PR by tagging `@coderabbitai` in a comment. - You can tag `@coderabbitai` in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`
levino commented 8 months ago

It seems to work. I also asked in nextjs on how to improve the set up.

thomasdavis commented 8 months ago

lgtm but there is a merge conflict

levino commented 8 months ago

The build script does not work correctly yet. Somehow the output is incompatible with resumed. Needs investigation.

levino commented 8 months ago

Handlebars is simply a failed technology. The approach I finally came up with might work for a while. However the questionable implementation of handlebars means, that all templates and partials will be stuck to the global Handlebars module and as such will overwrite each other once names run out. There is no way around it, I fear since all other solutions did not work. We should not support themes based on handlebars in the future and migrate the ones we have to react (or svelte, vue, angular, whatever, just NOT HANDLEBARS).

levino commented 8 months ago

Merging this. Hopefully then the magic is going to happen.