search

jsonresume / jsonresume.org

The mono repo that builds the homepage, utils, ui components, registry and anything else
https://jsonresume.org
66 stars 17 forks source link

Feature/Bump minyma theme version to 0.0.4 #56

Closed godraadam closed 8 months ago

godraadam commented 8 months ago

To address Vercel's edge runtime not supporting fs.readFileSync I simply inlined the markup template string in the theme, and bumped the version number accorsingly to 0.0.3 in apps/registry/package.json.

changeset-bot[bot] commented 8 months ago

⚠️ No Changeset found

Latest commit: 4810e1d421470b1bc73a48fb340c5ae19a54e864

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jsonresume-org-homepage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 0:08am
jsonresume-org-registry ❌ Failed (Inspect) Dec 8, 2023 0:08am
vercel[bot] commented 8 months ago

@godraadam is attempting to deploy a commit to the JSON Resume Team on Vercel.

A member of the Team first needs to authorize it.

thomasdavis commented 8 months ago

@godraadam something is wrong with the frozen lock file so I just created another PR to update it.

https://github.com/jsonresume/jsonresume.org/pull/57

And thanks for updating that. I know it sucks, and I am trying to figure out a work around. fs.readFileSync does work, but it is not "working" when in combination with turbo repo. The file doesn't exist because the vercel bundling refuses to include those css/partials.

But thanks again, will ping you when I finally figure it out.