Closed thomasdavis closed 8 months ago
vercel[bot]
commented
8 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| jsonresume-org-homepage | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Dec 9, 2023 0:09am |
| jsonresume-org-registry | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Dec 9, 2023 0:09am |
thomasdavis
commented
8 months ago @godraadam It doesn't look like 0.0.3 actually works -> https://jsonresume-org-registry-git-minyma-jsonresume.vercel.app/thomasdavis?theme=minyma
Going to check out your repo now
thomasdavis
commented
8 months ago @godraadam Your styles will also have to be inlined
(You can also just make them styles.js and then
export default `
p {};
`and then import them into your index.js file.
if you want to split the files up)
Once you published 0.0.4, I will update this PR and merge.
godraadam
commented
8 months ago @thomasdavis should be good now (hopefully).
Ended up writing a script which automatically outputs a js module thats export styles and the template for inlining. Pretty sure it is a backwards solution, but will do for now.
thomasdavis
commented
8 months ago @godraadam http://registry.jsonresume.org/thomasdavis?theme=minyma
looking good.
i swear i will solve this readFileSync problem
a script is actually a good idea (in this circumstance), will think more about it.
⚠️ No Changeset found
Latest commit: a9d598fe0b495fae1ea8c8c27f185bf872609793
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver typesClick here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR