jsonresume / jsonresume.org

The mono repo that builds the homepage, utils, ui components, registry and anything else
https://jsonresume.org
66 stars 17 forks source link

feat: enable ci checks for release PRs #64

Closed levino closed 8 months ago

levino commented 8 months ago

Summary by CodeRabbit

changeset-bot[bot] commented 8 months ago

⚠️ No Changeset found

Latest commit: dd76900b414bd28255ac4036025207e21bbcf31d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jsonresume-org-homepage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 10:22am
jsonresume-org-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 10:22am
coderabbitai[bot] commented 8 months ago

Walkthrough

The changes to the repository's workflow entail removing branch restrictions for the push trigger, introducing a step to create a GitHub App token, and adjusting the usage of the GITHUB_TOKEN environment variable to utilize the newly generated token. These modifications aim to enhance the release process automation by enabling runs on all branches and employing a more secure or specific GitHub App token for operations.

Changes

File Path Change Summary
.github/workflows/release.yml Removed branch push trigger restrictions, added token generation step, updated GITHUB_TOKEN usage

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - You can reply to a review comment made by CodeRabbit. - You can tag CodeRabbit on specific lines of code or files in the PR by tagging `@coderabbitai` in a comment. - You can tag `@coderabbitai` in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`
levino commented 8 months ago

The rabbit does not get it: When one creates PRs with the usual "github_token", no checks run in the PR. This is a design choice by github to prevent endless loops. In order to run github actions from PRs created by github actions, one has to use a "fully powered github token". One can either create a personal token, which is quite dangerous, or the proper way is to use a specific github app with limited access rights.