jsonresume / registry-functions

DEPRECATED - SEE MONO REPO -
https://github.com/jsonresume/jsonresume.org
19 stars 21 forks source link

Request a theme #7

Closed thomasdavis closed 1 year ago

thomasdavis commented 4 years ago

If you want to add an official theme please make a pull request where you add it to ./functions/package.json once accepted, the branch will automatically be deployed to firebase using Github actions.

thomasdavis commented 4 years ago

Also try to include a screenshot or live demo in the PR.

sundowndev commented 4 years ago

I get redirected to this issue even for using official themes resume serve --port 8080 --theme paper

Poslovitch commented 4 years ago

Same here, with resume serve --theme onepage

lfarci commented 4 years ago

I just got redirected here too after executing resume serve --theme paper resume.json.

Edit: my bad, after installing the jsonresume-theme-paper npm package globally, I was able to successfully use the official theme.

thomasdavis commented 4 years ago

Hrmmmm can you paste full output

Try to install theme globally on your comp

Npm I -g jsonresume-theme-paper

mubarakshow commented 4 years ago

Solved if you tried to install in a project rather than globally, you can do the following to run.

1) go into the node_modules folder cd node_module 2) go into the installed theme folder cd jsonresume-theme-{theme name} 3) add your resume.json file to the root of the theme 4) run this command: resume serve

TARIQvs commented 4 years ago

Even the above solution didn't work for me. But global installation is a help.

thomasdavis commented 4 years ago

Going to take a look tonight to see if there is any better solutions or at least add some helper text.

cphoover commented 3 years ago

I thought it was supposed to find custom themes you are developing local to the root of the project (outside of node_modules)

jackkeller commented 3 years ago

How are updates to themes handled? If I submit a PR for one but then update it at a later date is that a new PR with a version bump?

thomasdavis commented 2 years ago

@jackkeller yes, the new PR just requires to change the version.