search

jsonresume / registry-server

This repo is deprecated in favor of https://github.com/jsonresume/registry-functions
https://github.com/jsonresume/registry-functions
MIT License
95 stars 46 forks source link

Remove API Keys #10

Open erikringsmuth opened 10 years ago

erikringsmuth commented 10 years ago

You should probably move API keys to a separate config file that isn't checked into the git repo.

Ex: https://github.com/jsonresume/registry-server/blob/master/server.js#L17

nconf is a good tool for this https://github.com/flatiron/nconf.

thomasdavis commented 10 years ago

aha was waiting until someone noticed, we are using ENV variables for most things but I got lazy and committed my PDF conversion key

thomasdavis commented 10 years ago

The whole server was a rapid prototype, needs a refactor