Open bollwyvl opened 10 years ago
Wow, fantastic work! I will do a quick review this evening.
Any chance this will be merged? I'd like to use these tests...
@thomasdavis did you have a chance to review this PR?
@bollwyvl can you rebase please? Sorry it's been so long!
Sure, sounds like a gas, if there is any chance of it being reviewed. The json-ld spec hasn't changed, so there shouldn't be any surprises from that side. There are a few new schema.org types worth looking at, but i haven't been keeping up with this spec, so there may be some new structures that can't be mapped cleanly... Ld is really better at flat structures or meaningful lists/sets, less good at hierarchy for human readability or developer convenience.
On 11:09, Sun, May 31, 2015 Dan Kaplun notifications@github.com wrote:
@thomasdavis https://github.com/thomasdavis did you have a chance to review this PR?
@bollwyvl https://github.com/bollwyvl can you rebase please? Sorry it's been so long!
— Reply to this email directly or view it on GitHub https://github.com/jsonresume/registry-server/pull/15#issuecomment-107203726 .
@bollwyvl , I'd like to get this stuff merged in as it seems like it's fairly well supported. A few things first. Would you mind publishing your modules to npm so that we can set the versions? I'm not sure that it's a good Idea having them in production just pointing to your GitHub.
Terrible rebase. Going to start over off current master.
re: modules... as i mention on jsonresume/resume-schema#42, many modules will have to be updated before this can actually land... I'll concentrate on getting it back up and running, then we can talk about npm stuff.
re: support: schema.org at some point added some estimates of domain penetration of different nouns and adjectives. For example, givenName is estimated to be on:
Usage: Between 10,000 and 50,000 domains
Compare this with the reuse of, say, json schema, and i'd say it's going to be worthwhile.
Additionally, google's support for actions, with some appropriate things on the site will make magical things happen: View this resume
right in the listing of gmail/inbox of your recipient, looking like google put it there? yes, please.
As per #42 and schema PR.
Adds Travis-CI config, and tests for user create, user add, resume add, get context and get resume (json and jsonld).
Here's a build: https://travis-ci.org/bollwyvl/registry-server/builds/29566766
Hope this turns out to be interesting!